-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding media type support #162
base: master
Are you sure you want to change the base?
Conversation
Thanks for your PR! As I never used the media feature with neither Eve nor Eve-SQLAlchemy: If I understand the docs and your posts in #161 correctly, this is not enough to actually make Eve-SQLAlchemy accept and store files, right? Ideally we would have a working example or even integration test for this feature. In any case we should update the docs too, as Eve docs just mention the use of GridFS, which I suppose is not the storage system of choice for Eve-SQLAlchemy users. |
Ya, thats true, we could provide a file system based storage. I have a working example of that. it takes in a |
Hi! |
fyi - forked, merged/implemented changes from this pr. With s3-storage plugin (https://github.com/gwainer/eve-s3storage/) implemented file storage on S3. It works. p.s. there is a bug in eve-s3storage related to base64 encoding if |
I'm open to merging this - but don't really have time at the moment to update the docs myself. IMO we should at least add an example on how to use this, as Eve's docs will not apply here (it mentions that GridFS is used by default). If you could step in, rebase this on current master and add a short section on how to get this up and running, I think we're good to go! :-) |
I might try this. Haven't committed anything to public open-source project. Might need an assistance. |
No problem there - there's always a first! You can start by copying Once you've got something, just create a PR (even if it's not ready yet), so I can give feedback. |
as
Eve
documentation says it supports uploading media/files bymedia
type. this commit is just following the example at http://python-eve.org/features.html#file-storage. One test is added for checking the validity of it.