Skip to content

Remove unnecessary for loop when using get_axis_num #8356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Remove unnecessary for loop when using get_axis_num #8356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84aac6d
Tuple loop is not needed
Illviljan Oct 21, 2023
29bdfa7
dims are usually tuple[Hashable, ...]
Illviljan Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xarray/core/variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2162,7 +2162,7 @@ def rolling_window(
raise ValueError(
f"Expected {name}={arg!r} to be a scalar like 'dim'."
)
dim = [dim]
dim = (dim,)

# dim is now a list
nroll = len(dim)
Expand Down Expand Up @@ -2193,7 +2193,7 @@ def rolling_window(
pads[d] = (win - 1, 0)

padded = var.pad(pads, mode="constant", constant_values=fill_value)
axis = tuple(self.get_axis_num(d) for d in dim)
axis = self.get_axis_num(dim)
new_dims = self.dims + tuple(window_dim)
return Variable(
new_dims,
Expand Down