Fix Sphinx dev error linkcheck_allowed_redirects #2205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests against the latest/dev Sphinx version have been seeing: > WARNING: The config value `linkcheck_allowed_redirects' has type `NoneType'; expected `dict'.
|
Since this is a small PR, I'm just going to apply it to #2204 so we can see all of the CI checks turn green on a single PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests against the latest/dev Sphinx version have been seeing:
While this is probably a regression on Sphinx's end, this PR is also a reasonable change on our end because it makes sense to set the conf.py variable,
linkcheck_allowed_redirectsto an empty dictionary for our test sites.