Add builtin_tools to Agent
#1722
Conversation
| for tool in builtin_tools: | ||
| if tool == 'web-search': | ||
| self._builtin_tools.append(WebSearchTool()) | ||
| else: | ||
| self._builtin_tools.append(tool) |
There was a problem hiding this comment.
It's easier to not have to handle string on the models, so we already do the transformation here.
| """ | ||
|
|
||
|
|
||
| class UserLocation(TypedDict, total=False): |
There was a problem hiding this comment.
It's easier to handle this in the models if it's a TypedDict, since it matches the type.
| @dataclass | ||
| class WebSearchTool(AbstractBuiltinTool): |
There was a problem hiding this comment.
From the DX POV, it's nicer for it to be a BaseModel or dataclass.
Docs Preview
|
| tools = list(model_settings.get('openai_builtin_tools', [])) + tools | ||
| tools = self._get_builtin_tools(model_request_parameters) + tools |
There was a problem hiding this comment.
We should deprecate the openai_builtin_tools in this PR.
| class AbstractBuiltinTool(ABC): | ||
| """A builtin tool that can be used by an agent. | ||
|
|
||
| This class is abstract and cannot be instantiated directly. |
There was a problem hiding this comment.
I think worth including a sentence here explaining how the code execution works to make use of them — something like "these are passed to the model as part of the ModelRequestParameters" or whatever. (Not sure if that's true, haven't gotten there yet ..). But I imagine it helping someone who is trying to figure out how they are different from normal tools.
Co-authored-by: Marcelo Trylesinski <[email protected]>
) Co-authored-by: Marcelo Trylesinski <[email protected]>
PR Change SummaryEnhanced documentation for the
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
No description provided.