Skip to content

clean up js packaging / smoke test#550

Merged
davidhewitt merged 4 commits into
mainfrom
dh/js-packaging
Jul 11, 2026
Merged

clean up js packaging / smoke test#550
davidhewitt merged 4 commits into
mainfrom
dh/js-packaging

Conversation

@davidhewitt

@davidhewitt davidhewitt commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

attempting to make the JS packaging pipeline assemble proper packages and smoke-test those before release


Summary by cubic

Reworks JS packaging to assemble proper @pydantic/monty and platform packages, smoke-test the packed tarballs across OS/arch and Node 20/24, and ensure the WASM runtime ships in the main package. We now reuse runtime worker binaries from Python wheels and only build the N-API addon in the JS build.

  • Refactors
    • Build only the N-API addon in CI; worker executables come from pydantic-monty-runtime wheels.
    • Add assemble-js-packages job to assemble, validate, and pack tarballs (includes WASM runtime).
    • Add test-js-packages matrix to install the tarballs and run a smoke test across OS/arch and Node 20/24.
    • Release publishes the tested tarballs and now depends on test-js-packages.
    • Replace bash smoke test with scripts/assemble-packages.mjs and smoke-test/package-smoke.mjs; remove Makefile smoke-test; rename artifacts from monty-bin-* to monty-addon-*.
    • Work around a maturin wheel duplication bug by selecting the CPython 3.10 runtime wheel when extracting the monty binary.

Written for commit 1c0a3ab. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/ci.yml Outdated
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 40958 uncovered lines.
✅ Project coverage is 49.72%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    49.64%    49.72%    +0.08%
==========================================
  Files          319       319         —
  Lines        81272     81458      +186
  Branches    172725    173094      +369
==========================================
+ Hits         40341     40500      +159
- Misses       40931     40958       +27
- Partials      3089      3099       +10

Generated by Codecov Action

@codspeed-hq

codspeed-hq Bot commented Jul 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 16 skipped benchmarks1


Comparing dh/js-packaging (1c0a3ab) with main (dd5fc71)

Open in CodSpeed

Footnotes

  1. 16 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@davidhewitt davidhewitt merged commit da22a4e into main Jul 11, 2026
66 checks passed
@davidhewitt davidhewitt deleted the dh/js-packaging branch July 11, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant