clean up js packaging / smoke test#550
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 40958 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 49.64% 49.72% +0.08%
==========================================
Files 319 319 —
Lines 81272 81458 +186
Branches 172725 173094 +369
==========================================
+ Hits 40341 40500 +159
- Misses 40931 40958 +27
- Partials 3089 3099 +10Generated by Codecov Action |
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempting to make the JS packaging pipeline assemble proper packages and smoke-test those before release
Summary by cubic
Reworks JS packaging to assemble proper
@pydantic/montyand platform packages, smoke-test the packed tarballs across OS/arch and Node 20/24, and ensure the WASM runtime ships in the main package. We now reuse runtime worker binaries from Python wheels and only build the N-API addon in the JS build.pydantic-monty-runtimewheels.assemble-js-packagesjob to assemble, validate, and pack tarballs (includes WASM runtime).test-js-packagesmatrix to install the tarballs and run a smoke test across OS/arch and Node 20/24.test-js-packages.scripts/assemble-packages.mjsandsmoke-test/package-smoke.mjs; remove Makefile smoke-test; rename artifacts frommonty-bin-*tomonty-addon-*.maturinwheel duplication bug by selecting the CPython 3.10 runtime wheel when extracting themontybinary.Written for commit 1c0a3ab. Summary will update on new commits.