Prototype type checking w/ pyrefly#501
Draft
yangdanny97 wants to merge 6 commits into
Draft
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Author
|
Ah, the numbers in the original post were outdated, I measured the wrong commit. The actual speed difference in repl is more like 3x; tho it varies based on the size of the thread pool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prototypes the ability to swap between using ty and Pyrefly as the type checker for Monty, via the
MONTY_TYPE_CHECKERenv var right now.The actual diff is small - Pyrefly exposes a minimal API that is easy to call, most of the remaining logic is refactoring to support 2 separate backends. There's just a lot of Cargo.lock churn from pulling in Pyrefly as a dependency.
For context, I believe @samuelcolvin spoke with @migeed-z at PyCon about this, and was open to us experimenting in this direction
It can't be merged in this state, because:
I'm putting this PR up just to get some early feedback. Let me know what you guys think!