Add ability to identify min_python version #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
feat/code
branch
5 times, most recently
from
8a66bd1 to
0ec7263
Compare
Member
Author
|
@RonnyPfannschmidt Please review. After implementing this, I will add one method for generating the JSON for GHA test matrix. |
Collaborator
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
IMHO ctors with logic ought to be avoid, they sabotage Testability among other details
| # written, this was the oldest still supported version of Python | ||
| min_python: str = "3.7" | ||
|
|
||
| def __init__(self, path: Union[Path, str] = Path(".")) -> None: |
Collaborator
There was a problem hiding this comment.
Please use a named constructor for the logic part
Member
Author
|
Any suggestions? I would prefer to keep usage as simple as possible. Initially i was considering avoiding a class but sooner or later we will want to read other info about the project. |
Collaborator
|
Use named constructors and/or a global construction function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.