Fix set_configuration_vm for multi-value configs (closes #192)#193
Open
martinmiglio wants to merge 1 commit into
Open
Fix set_configuration_vm for multi-value configs (closes #192)#193martinmiglio wants to merge 1 commit into
martinmiglio wants to merge 1 commit into
Conversation
memuc_run uses subprocess with shell=False, so a space-separated value like "270 480 120" was passed as a single argv slot and rejected with 'invalid config parameter'. Split on whitespace so configs that take multiple tokens (e.g. custom_resolution, geometry) are forwarded as separate args, matching the memuc CLI's expectations. Closes #192
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_configuration_vmpassedconfig_valueas a single argv slot, so multi-token values likecustom_resolution="270 480 120"reachedmemuc.exequoted as one parameter and were rejected withERROR: invalid config parameter.config_valueon whitespace and unpack into thememuc_runargs, matching the CLI shape that works in a shell. Single-value configs are unaffected.Fix proposed by @Broadsword in #192.
Test plan
memuc.set_configuration_vm(vm_index=0, config_key="custom_resolution", config_value="270 480 120")and confirmSUCCESS: setconfig finished.cpus) still works.geometrywhich the reporter suspected has the same issue.