Update external dependency retrieval from WORKSPACE to MODULE to support bzlmod #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laramiel
reviewed
Jan 8, 2024
|
LGTM — But I don't have a lot of relevant background. @laramiel could you please confirm? I'll need to import this change manually. (The source of truth for this repo is the Google-internal SCM system.) This change will then get auto-exported from there. |
1 task
|
Is this PR making its way through the system? Once it's there, we should consider adding a versioned release so that we can add this library to the BCR (https://registry.bazel.build/) |
|
Just to make a connection that may be relevant (not sure): pybind/pybind11_bazel#72 @junyer for awareness. |
|
Supporting Bzlmod is on @david-crouse's radar. :D |
|
This is resolved thanks to b4a2e87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step to support the changes outlined in https://blog.bazel.build/2023/07/24/whats-new-with-bzlmod.html