Remove two pool-membership conditions guarding the C++ equivalent of obj.SerializePartialToString()
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/589031333
branch
from
9289780 to
ec48400
Compare
copybara-service
bot
changed the title
PyProtoSerializePartialToString()PyProtoIsCompatible():
copybara-service
bot
force-pushed
the
cl/589031333
branch
from
ec48400 to
70403fb
Compare
copybara-service
bot
changed the title
PyProtoIsCompatible():obj.SerializePartialToString()
copybara-service
bot
force-pushed
the
cl/589031333
branch
from
70403fb to
29e8571
Compare
copybara-service
bot
force-pushed
the
cl/589031333
branch
from
29e8571 to
8359a09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove two pool-membership conditions guarding the C++ equivalent of
obj.SerializePartialToString()The main change in this CL is to remove two conditions in
PyProtoIsCompatible():Rationale for removing these conditions:
All that matters for protobuf compatibility is that the
full_nameis the same. (Thanks @kmoffett for that insight!)Cross-extension-module ABI compatibility is not a concern because only the Python API is used in the relevant code paths serializing Python protobuf objects to Python
bytes(equivalent to callingobj.SerializePartialToString()from Python).All other changes in this CL are secondary: small-scale refactoring, slight naming changes, additional tests for error conditions.