Skip to content

Make python SDK targets configurable #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsharpe
Copy link

@jsharpe jsharpe commented Jul 22, 2025

Make the python sdk targets configurable so that they can be overriden with e.g.@python_3_12//:python_headers to avoid needing to transition the current python toolchain to another version.

Fixes:

@jsharpe jsharpe force-pushed the configurable_python_sdk branch from dc1b85f to 2f2fb8f Compare July 22, 2025 10:31
@Mizux Mizux self-assigned this Jul 22, 2025
@Mizux
Copy link
Collaborator

Mizux commented Jul 22, 2025

Seems to follow the intended use of rules_python
src: https://github.com/bazel-contrib/rules_python/blob/main/tests/cc/current_py_cc_libs/BUILD.bazel

question: why not naming them py_cc_header and py_cc_libs i.e.

 py_cc_headers = "@rules_python//python/cc:current_py_cc_headers",

@jsharpe
Copy link
Author

jsharpe commented Jul 22, 2025

Not particularly attached to any name in particular but I named it based on the target you'd typically override it with i.e. https://github.com/bazel-contrib/rules_python/blob/5281261a97235099a65aaeb83b74b30d16409798/python/private/hermetic_runtime_repo_setup.bzl#L110 - the python_headers target from a specific python version e.g. @python_3_10//:python_headers.

@Mizux Mizux added the enhancement New feature or request label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants