Fixed array_t type hint - #5353
Closed
gentlegiantJGC wants to merge 3 commits into
Closed
gentlegiantJGC wants to merge 3 commits into
gentlegiantJGC wants to merge 3 commits into
Conversation
Skylion007
approved these changes
Sep 3, 2024
Skylion007
left a comment
Skylion007
left a comment
Collaborator
There was a problem hiding this comment.
I'm kind of shocked none of the linters complained before.
Skylion007
requested changes
Sep 3, 2024
Skylion007
left a comment
Skylion007
left a comment
Collaborator
There was a problem hiding this comment.
Actually, this is the same as: https://github.com/pybind/pybind11/pull/5212/files We should probably merge that PR.
Contributor
Author
|
I missed that pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed type hint for
pybind11::array_tFixes #5352
Suggested changelog entry:
Fixed type hint for `pybind11::array_t`