Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for issue #5020: silent conversion to float #5025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests for issue #5020: silent conversion to float #5025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/test_enum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@ TEST_SUBMODULE(enums, m) {
m.def("test_enum_to_uint", [](uint32_t) {});
m.def("test_enum_to_long_long", [](long long) {});

// Trying to pass an enum to a function that accepts a float should
// trigger a type error
m.def("test_enum_to_float", [](double) {});

// When performing overload resolution, calling f(0, ScopedEnum.TWO)
// should select f(float, ScopedEnum), NOT f(float, float)
m.def("test_enum_overload_resolution", [](double, double) { return "f(float, float)"; });
m.def("test_enum_overload_resolution",
[](double, ScopedEnum) { return "f(float, ScopedEnum)"; });

// test_duplicate_enum_name
enum SimpleEnum { ONE, TWO, THREE };

Expand Down
22 changes: 22 additions & 0 deletions tests/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,28 @@
m.test_enum_to_long_long(m.ScopedBoolEnum.TRUE)


def test_enum_overload_resolution():
"""When performing overload resolution, enums should not be silently
converted to floats"""
assert m.test_enum_overload_resolution(0.0, 0.0) == "f(float, float)"
assert m.test_enum_overload_resolution(0, 0) == "f(float, float)"
assert (
m.test_enum_overload_resolution(0.0, m.ScopedEnum.Two) == "f(float, ScopedEnum)"
)
assert (

Check failure on line 240 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 3.9 • ubuntu-20.04 • x64 

test_enum_overload_resolution

AssertionError: assert 'f(float, float)' == 'f(float, ScopedEnum)'
  - f(float, ScopedEnum)
  + f(float, float)

Check failure on line 240 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 3.10 • ubuntu-20.04 • x64 

test_enum_overload_resolution

AssertionError: assert 'f(float, float)' == 'f(float, ScopedEnum)'
  - f(float, ScopedEnum)
  + f(float, float)

Check failure on line 240 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 3.12 • ubuntu-20.04 • x64 

test_enum_overload_resolution

AssertionError: assert 'f(float, float)' == 'f(float, ScopedEnum)'
  - f(float, ScopedEnum)
  + f(float, float)

Check failure on line 240 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 3.11 • ubuntu-20.04 • x64 

test_enum_overload_resolution

AssertionError: assert 'f(float, float)' == 'f(float, ScopedEnum)'
  - f(float, ScopedEnum)
  + f(float, float)

Check failure on line 240 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 pypy-3.8 • ubuntu-20.04 • x64 -DPYBIND11_FINDPYTHON=ON 

test_enum_overload_resolution

AssertionError: assert 'f(float, float)' == 'f(float, ScopedEnum)'
  - f(float, ScopedEnum)
  + f(float, float)

Check failure on line 240 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 pypy-3.9 • ubuntu-20.04 • x64 

test_enum_overload_resolution

AssertionError: assert 'f(float, float)' == 'f(float, ScopedEnum)'
  - f(float, ScopedEnum)
  + f(float, float)
m.test_enum_overload_resolution(0, m.ScopedEnum.Two) == "f(float, ScopedEnum)"
)


def test_enum_to_float():
"""Passing an enum to a function taking a float should trigger a type error"""
with pytest.raises(TypeError) as execinfo:

Check failure on line 247 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 3.10 • ubuntu-20.04 • x64 

test_enum_to_float

Failed: DID NOT RAISE <class 'TypeError'>

Check failure on line 247 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 3.12 • ubuntu-20.04 • x64 

test_enum_to_float

Failed: DID NOT RAISE <class 'TypeError'>

Check failure on line 247 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 3.11 • ubuntu-20.04 • x64 

test_enum_to_float

Failed: DID NOT RAISE <class 'TypeError'>
m.test_enum_to_float(m.ScopedBoolEnum.TRUE)

Check failure on line 248 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 3.9 • ubuntu-20.04 • x64 

test_enum_to_float

Failed: DID NOT RAISE <class 'TypeError'>

Check failure on line 248 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 pypy-3.8 • ubuntu-20.04 • x64 -DPYBIND11_FINDPYTHON=ON 

test_enum_to_float

Failed: DID NOT RAISE <class 'TypeError'>

Check failure on line 248 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 pypy-3.9 • ubuntu-20.04 • x64 

test_enum_to_float

Failed: DID NOT RAISE <class 'TypeError'>
assert str(execinfo.value).startswith(

Check failure on line 249 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 3.6 • ubuntu-20.04 • x64 -DPYBIND11_FINDPYTHON=ON -DCMAKE_CXX_FLAGS="-D_=1" 

test_enum_to_float

AssertionError: assert False
 +  where False = <built-in method startswith of str object at 0x7f7da7459108>('TypeError: test_enum_to_float(): incompatible function arguments.')
 +    where <built-in method startswith of str object at 0x7f7da7459108> = 'test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>'.startswith
 +      where 'test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>' = str(TypeError('test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>',))
 +        where TypeError('test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>',) = <ExceptionInfo TypeError('test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>',) tblen=1>.value

Check failure on line 249 in tests/test_enum.py

View workflow job for this annotation

GitHub Actions / 🐍 pypy-3.10 • ubuntu-20.04 • x64 

test_enum_to_float

AssertionError: assert False
 +  where False = <bound method str.startswith of 'test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>'>('TypeError: test_enum_to_float(): incompatible function arguments.')
 +    where <bound method str.startswith of 'test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>'> = 'test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>'.startswith
 +      where 'test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>' = str(TypeError('test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>'))
 +        where TypeError('test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>') = <ExceptionInfo TypeError('test_enum_to_float(): incompatible function arguments. The following argument types are supported:\n    1. (arg0: float) -> None\n\nInvoked with: <ScopedBoolEnum.TRUE: 1>') tblen=1>.value
"TypeError: test_enum_to_float(): incompatible function arguments."
)


def test_duplicate_enum_name():
with pytest.raises(ValueError) as excinfo:
m.register_bad_enum()
Expand Down
Loading