[smart_holder] clang-tidy fixes (related to recent clang-tidy changes on master). #3053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
approved these changes
Jun 21, 2021
Skylion007
reviewed
Jun 21, 2021
| @@ -44,4 +44,4 @@ jobs: | |||
| -DCMAKE_CXX_STANDARD=17 | |||
|
|
|||
| - name: Build | |||
| run: cmake --build build -j 2 | |||
| run: cmake --build build -j 2 -- --keep-going | |||
There was a problem hiding this comment.
Thanks. It was indeed super annoying to not get all the clang-tidy errors.
There was a problem hiding this comment.
@Skylion007 Do you prefer to adopt this in your PR #3051, or do you think it's better if I open a mini PR to add this to master?
henryiii
changed the title
|
Close-Reopen to retrigger GitHub Actions. There were many "cannot find linux asset" or "win32 asset" errors. |
|
Ignoring two notorious flakes: 1. macos runner not available, 2. #2995. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding
--keep-goingtocmakebuildcommand, to get all clang-tidy errors at once.