-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exporter to a local MongoDB #463
Open
amanchoudhri
wants to merge
48
commits into
master
Choose a base branch
from
add-mongo-exporter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, get_edges() could be called either with: a node as an input or criteria to search for matching nodes as the input Now, those two input sets are broken up into smaller functions
Needs unit tests! |
cthoyt
reviewed
Aug 1, 2020
cthoyt
reviewed
Aug 1, 2020
cthoyt
reviewed
Aug 1, 2020
cthoyt
reviewed
Aug 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 78.30% 78.33% +0.03%
==========================================
Files 176 177 +1
Lines 9443 9555 +112
Branches 1364 1387 +23
==========================================
+ Hits 7394 7485 +91
- Misses 1762 1775 +13
- Partials 287 295 +8
Continue to review full report at Codecov.
|
Before, there was a lot of repetition in deleting the '_id' and 'type' keys from mongo items. This commit makes that more DRY by pulling that functionality out into _rm_mongo_keys().
cthoyt
reviewed
Aug 6, 2020
cthoyt
reviewed
Aug 6, 2020
cthoyt
reviewed
Aug 6, 2020
cthoyt
reviewed
Aug 6, 2020
cthoyt
reviewed
Aug 6, 2020
cthoyt
reviewed
Aug 6, 2020
cthoyt
reviewed
Aug 6, 2020
…nto add-mongo-exporter
cthoyt
reviewed
Aug 12, 2020
cthoyt
reviewed
Aug 12, 2020
cthoyt
reviewed
Aug 12, 2020
cthoyt
reviewed
Aug 12, 2020
…nto add-mongo-exporter
In the previous "Parse found nodes to dsl" commit tests were failing. This commit adds a new function to ensure that querying for edges still works as expected, and all mongodb tests now pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions to export a given graph to a local MongoDB and then query some basic information back from that DB.