Skip to content

Conversation

@medha-14
Copy link
Collaborator

No description provided.

@medha-14
Copy link
Collaborator Author

I have created this pull request to test whether the entry point API is working as expected. The example notebook included here is for demonstration purposes and can be refined and added to the PyBaMM repository once approved. Please have a look and suggest any changes if needed.

@agriyakhetarpal
Copy link
Member

Thank you! I've launched the workflows.

@medha-14
Copy link
Collaborator Author

medha-14 commented Jul 22, 2025

Could I get some help with the test_parameter_sets_entry_point_load failure, not sure why the dicts aren’t matching anymore. Only difference I can see is "citations" vs "notcite", am i missing something? What could be causing this?

@agriyakhetarpal
Copy link
Member

Hmm, the only source of truth for notcite across both the PyBaMM and pybamm-cookie repositories is here:

Perhaps this can help? I don't recall the context in which this was added, as it has been a while. Perhaps @santacodes does 🤔

@santacodes
Copy link
Member

Hmm, the only source of truth for notcite across both the PyBaMM and pybamm-cookie repositories is here:

Perhaps this can help? I don't recall the context in which this was added, as it has been a while. Perhaps @santacodes does 🤔

I don't exactly recall this @agriyakhetarpal, as they worked out of the box when I copied and pasted these parameter values here to test the entry points.

@santacodes
Copy link
Member

@medha-14 could you check the failing tests, I think we can merge this once you get the tests passing.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please update the notebook and the source files to use PyBaMM >= 25.8, and we should be good to go. I'll delegate to @santacodes to review the notebook in detail and provide his final go-ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants