_pkcs11.pyx: Fix Python int too large to convert to C ssize_t #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a key is retrieved it can retrun CK_UNAVAILABLE_INFORMATION for some of its properties. The CK_UNAVAILABLE_INFORMATION value is set to ~0UL or the largest int possible on a system. The python-pkcs11 library would then try to create a buffer of that size and crash. This commit adds error checking to make sure when CK_UNAVAILABLE_INFORMATION is returned that the property value is set to blank and returned immediately.
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a key is retrieved it can return CK_UNAVAILABLE_INFORMATION for some of its properties. The CK_UNAVAILABLE_INFORMATION value is set to ~0UL or the largest int possible on a system. The python-pkcs11 library would then try to create a buffer of that size and crash.
This commit adds error checking to make sure when
CK_UNAVAILABLE_INFORMATION is returned that the property value is set to blank and returned immediately.