Skip to content

Nested containers #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Nested containers #704

wants to merge 4 commits into from

Conversation

ndxmrb
Copy link

@ndxmrb ndxmrb commented Jun 19, 2025

Hi @tlambert03,
restarting my work from #669 after the ValuedContainer changes.

Still, some things are missing:

Tried my best with the types again, hope it's okay that way.

Thanks for having a look!

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.15%. Comparing base (45a54d1) to head (0b88814).

Files with missing lines Patch % Lines
src/magicgui/schema/_ui_field.py 41.66% 7 Missing ⚠️
src/magicgui/widgets/bases/_container_widget.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
- Coverage   89.28%   89.15%   -0.14%     
==========================================
  Files          40       40              
  Lines        4816     4831      +15     
==========================================
+ Hits         4300     4307       +7     
- Misses        516      524       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant