Skip to content

Rename solar position inputs in tracking.singleaxis #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Jun 8, 2025

  • Closes tracking.singleaxis takes apparent_azimuth #2479
  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Rename the inputs to the tracking.singleaxis function. Specifically, apparent_zenith -> solar_zenith and apparent_azimuth --> solar_azimuth

@AdamRJensen AdamRJensen added this to the v0.13.1 milestone Jun 8, 2025
@AdamRJensen AdamRJensen marked this pull request as ready for review June 8, 2025 20:24
Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
apparent_zenith has a lot of occurrences so I've not reviewed them all. apparent_azimuth only seems to exist as positional arguments in test_tracking.py. I don't think they deserve to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracking.singleaxis takes apparent_azimuth
3 participants