Skip to content

removed duplicate import of datetime #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

removed duplicate import of datetime #2134

merged 1 commit into from
Jul 17, 2024

Conversation

PhilBrk8
Copy link
Contributor

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

two import statements of datetime:
import datetime
import datetime as dt

in the code, 'datetime' was only used once, so I changed it to dt and removed the redundant import

@cwhanse
Copy link
Member

cwhanse commented Jul 16, 2024

Looks fine to me, thanks @PhilBrk8

@cwhanse
Copy link
Member

cwhanse commented Jul 16, 2024

In the future, it is a good practice to prepare changes in a branch, rather than in your main branch. If you use git at the command line, the sequence is:

  1. git checkout main
  2. git pull upstream main - to be sure you start from the latest, upstream points to github.com/pvlib/pvlib-python.git
  3. git checkout -b - make a new branch for the changes

Now edit / git add / git commit / git push etc. and then submit the new branch as your PR.

@AdamRJensen AdamRJensen added this to the v0.11.1 milestone Jul 17, 2024
@AdamRJensen AdamRJensen merged commit 0d09130 into pvlib:main Jul 17, 2024
31 checks passed
@AdamRJensen
Copy link
Member

Thanks @PhilBrk8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants