Skip to content

Enhance description of unit_mass in prilliman temperature model #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

AdamRJensen
Copy link
Member

  • I am familiar with the contributing guidelines
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I had initially understood the one-sided surface area as the "area of the side of the module", e.g., module width times module thickness, which of course is not correct. I think this added line makes it a bit clearer.

@AdamRJensen AdamRJensen changed the title Add description to prilliman unit_mass Enhance description of unit_mass in prilliman temperature model Sep 15, 2023
@kandersolar kandersolar added this to the v0.10.2 milestone Sep 15, 2023
@kandersolar kandersolar merged commit 664f884 into pvlib:main Sep 15, 2023
@AdamRJensen AdamRJensen deleted the onesided_surface_area branch September 15, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants