Skip to content

create local_projection #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwhanse merged 5 commits into from
Mar 4, 2026
Merged

create local_projection #58

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb59605
create local_projection
cwhanse Feb 19, 2026
a412818
make optional
cwhanse Feb 20, 2026
71b73c0
add note to local_projection
cwhanse Feb 23, 2026
c6c2402
characters
cwhanse Feb 27, 2026
b13be44
Update schema/pvcollada_schema_2.0.xsd
cwhanse Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions schema/pvcollada_schema_2.0.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,15 @@ xmlns:collada="http://www.collada.org/2008/03/COLLADASchema">
1.0</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="local_projection" type="xs:string" minOccurs="0">
<xs:annotation>
<xs:documentation xml:lang="en">ESPG code for a projection to associate local coordinates (x,y,z) with geocoordinates (lat-long). Format as "ESPG:3857", for example.
The geocoordinates of the origin of the local coordinate system are specified in WG84 latitude, longitude and altitude in the root &lt;COLLADA&gt;&lt;asset&gt;&lt;coverage&gt;
block of data. Specify altitude as height above sea level, i.e., &lt;altitude mode="absolute"&gt;.
The local coordinates of an object are distances in x (East), y (North), z (Up) from the origin. Apply the projection specified by the ESPG code to convert the origin latitude longitude to
the corresponding point in the projection, use that point to map local coordinates to their projection coordinates and then their geocoordinates.</xs:documentation>
</xs:annotation>
Comment on lines +738 to +743
Copy link
Copy Markdown
Member Author

@cwhanse cwhanse Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:documentation xml:lang="en">ESPG code for a projection to associate local coordinates (x,y,z) with geocoordinates (lat-long). Format as "ESPG:3857", for example.
The geocoordinates of the origin of the local coordinate system are specified in WG84 latitude, longitude and altitude in the root &lt;COLLADA&gt;&lt;asset&gt;&lt;coverage&gt;
block of data. Specify altitude as height above sea level, i.e., &lt;altitude mode="absolute"&gt;.
The local coordinates of an object are distances in x (East), y (North), z (Up) from the origin. Apply the projection specified by the ESPG code to convert the origin latitude longitude to
the corresponding point in the projection, use that point to map local coordinates to their projection coordinates and then their geocoordinates.</xs:documentation>
</xs:annotation>
<xs:documentation xml:lang="en">EPSG code for a projection to associate local coordinates (x,y,z) with geocoordinates (lat-long). Format as "EPSG:3857", for example.
The geocoordinates of the origin of the local coordinate system are specified in WG84 latitude, longitude and altitude in the root &lt;COLLADA&gt;&lt;asset&gt;&lt;coverage&gt;
block of data. Specify altitude as height above sea level, i.e., &lt;altitude mode="absolute"&gt;.
The local coordinates of an object are distances in x (East), y (North), z (Up) from the origin. The unit
for distance is specified at &lt;COLLADA&gt;&lt;asset&gt;&lt;unit&gt;. Apply the projection specified by the EPSG code to convert the origin's latitude and longitude to
the corresponding point in the projection, use that point to map local coordinates to their projection coordinates and then to their geocoordinates.</xs:documentation>
</xs:annotation>

Copy link
Copy Markdown
Member Author

@cwhanse cwhanse Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikehamer1 fixed the typos and added a sentence about units

Copy link
Copy Markdown
Collaborator

@mikehamer1 mikehamer1 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Quick work. The changes look good. I think it's good to merge - at least from my point of view.

</xs:element>
<xs:element name="boundary" type="collada:sidref_type" minOccurs="0">
<xs:annotation>
<xs:documentation xml:lang="en">SIDREF for a COLLADA instance_geometry describing the project boundary.</xs:documentation>
Expand Down