Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template overhaul spr2024 #290

Merged
merged 50 commits into from
Mar 14, 2024
Merged

Template overhaul spr2024 #290

merged 50 commits into from
Mar 14, 2024

Conversation

jessestorbeck
Copy link
Contributor

@jessestorbeck jessestorbeck commented Mar 13, 2024 •
edited
Loading

jessestorbeck and others added 30 commits January 25, 2024 16:25
@jessestorbeck
upgrade commander
6b6fe79
@jessestorbeck
package-ify the basic site template
a506bd0 
The site template is now a package that unzips the template contents into the user's site directory
@jessestorbeck
update README img tag
8506189
@jessestorbeck
First try at new install site
5e57b2f
@jessestorbeck
Finishing up new install site from path
22d07e1
@jessestorbeck
finishing up new install site
36d3b7f 
Went back to single `handleInstall` function, but combined common functionality for site and exp templates
@jessestorbeck
call getTemplates() with @pushkin-templates scope
3c69565
@jessestorbeck
add package script to include license before publishing
a4bf5ba
@jessestorbeck
First try at new install site
a9c4362
@jessestorbeck
yarn upgrade <package> triggering postinstall for all packages?
af8a2a4
@jessestorbeck
install site and install exp working now with template from path
ce23b88
@jessestorbeck
new basic site and exp working for localhost testing
257f830
@jessestorbeck
Add "are you sure?" prompt if cwd has contents prior to install site
e79b413
@jessestorbeck
changeset for install site "are you sure?" prompt
2421b20
@jessestorbeck
Add changesets for basic templates
046ed03
@jessestorbeck
Convert the experiment templates into packages
838e225
@jessestorbeck
Add jspsych experiment import back into handleInstall()
eca3f62
@jessestorbeck
Add documentation for the install site and install experiment fun…
9f854f3 
…ctions
@jessestorbeck
Update other exp template config files to match "pushkintemplate" nam…
f18f74e 
…es in basic template
@jessestorbeck
Update migrations files renaming
6a00981
@jessestorbeck
remove placeholders from assets, add timeline assets folders to non-b…
664e886 
…asic exp templates
@jessestorbeck
attempt to mitigate unzip before package install finishes
b603d3a
@jessestorbeck
remove imports of old site/exp template functions
2299d7c
@jessestorbeck
add prepack scripts to include license from repo root
3e863b1
@jessestorbeck
Only call setEnv during install site and at the beginning of prep
42e4617
@hunterschep
add delete exp functionality
b5d34c2
@hunterschep
minor fixes
91f909b
@hunterschep
delete experiment directory
34f2c2b
@hunterschep
remove experiment docker components
ef1a517
@hunterschep
Update index.js
fecdcc9
hunterschep and others added 15 commits February 22, 2024 23:13
@hunterschep
add functions
1b599e3 
add handleinstall
add more functionality to remove timeline assets
@hunterschep
try to remove db tables
6edf261
@jessestorbeck
Jest tests in experiment templates now work after install exp
316d6ec
@hunterschep
update deletion functionality
5175775
@hunterschep
implement archive
5cfcc69
@hunterschep
fix expDirs
30b10d2
@hunterschep
add functionality
dbb0cbf
@jessestorbeck
Merge remote-tracking branch 'origin/main' into template-overhaul-spr…
15210c2 
…2024
@jessestorbeck
Updated --no-<x> flags for prep and start
ad84d51
@hunterschep
Update remove functionality
1b90942 
- Update remove to accept mode in long command
- Consolidate handler functions into one
@jessestorbeck
additional console.log
b078ebf
@hunterschep
update docs with remove
1de893d
@jessestorbeck
Merge remote-tracking branch 'origin/remove-experiment' into template…
0d44bb7 
…-overhaul-spr2024
@jessestorbeck
Refinements to remove experiment
7703288
@jessestorbeck
doc comment for handleRemove
1427f3b
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: cedf527

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@pushkin-templates/exp-grammaticality-judgment Major
@pushkin-templates/exp-self-paced-reading Major
@pushkin-templates/exp-lexical-decision Major
@pushkin-templates/exp-basic Major
pushkin-cli Major
@pushkin-templates/site-basic Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

hunterschep
hunterschep approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@hunterschep hunterschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in conjunction w/ our discussion today on this and the progress made over the last few weeks

@jessestorbeck jessestorbeck merged commit 6e53d20 into main Mar 14, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterschep hunterschep hunterschep approved these changes

@ayang21 ayang21 Awaiting requested review from ayang21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jessestorbeck @hunterschep