Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushkin logo on npm #251

Closed
jessestorbeck opened this issue Nov 16, 2023 · 2 comments · Fixed by #290
Closed

Pushkin logo on npm #251

jessestorbeck opened this issue Nov 16, 2023 · 2 comments · Fixed by #290
Assignees
Labels
good first issue Good for newcomers

Comments

@jessestorbeck
Copy link
Contributor

Currently, the logo doesn't display correctly for any pushkin packages on npm. I thought I fixed this the last few times I published updates, but it turns out the real problem is with their markdown parser and how it handles relative image paths (npm/marky-markdown#437). Replacing the img tag with this should do the trick:

<img src="https://raw.githubusercontent.com/pushkin-consortium/pushkin/master/pushkin_bw_w_text.png" height="400" width="450" alt="pushkin logo">

I made the change to worker in pushkin-consortium/pushkin-worker#29, but CLI, API, and client should have their readme updated accordingly. We can also ditch the images folder for each of these packages. In the case of CLI, "images/*" should be removed from the files property in package.json.

@jessestorbeck jessestorbeck added the good first issue Good for newcomers label Nov 16, 2023
@jessestorbeck jessestorbeck self-assigned this Dec 8, 2023
@hunterschep hunterschep self-assigned this Jan 18, 2024
@hunterschep
Copy link
Contributor

hunterschep commented Jan 18, 2024

Note: since we moved to a mono repo the link given above throws a 404, the correct link for the image is:

<img src="https://raw.githubusercontent.com/pushkin-consortium/pushkin/main/docs/img/pushkin_bw_w_text.png" height="400" width="450" alt="pushkin logo">

@hunterschep
Copy link
Contributor

@jessestorbeck @ayang21 I just fixed the image tags and opened Pr #266, once this is merge I can update the npm packages inside of main as I didn't want to npm publish from a branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants