You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the logo doesn't display correctly for any pushkin packages on npm. I thought I fixed this the last few times I published updates, but it turns out the real problem is with their markdown parser and how it handles relative image paths (npm/marky-markdown#437). Replacing the img tag with this should do the trick:
I made the change to worker in pushkin-consortium/pushkin-worker#29, but CLI, API, and client should have their readme updated accordingly. We can also ditch the images folder for each of these packages. In the case of CLI, "images/*" should be removed from the files property in package.json.
The text was updated successfully, but these errors were encountered:
@jessestorbeck@ayang21 I just fixed the image tags and opened Pr #266, once this is merge I can update the npm packages inside of main as I didn't want to npm publish from a branch
Currently, the logo doesn't display correctly for any pushkin packages on npm. I thought I fixed this the last few times I published updates, but it turns out the real problem is with their markdown parser and how it handles relative image paths (npm/marky-markdown#437). Replacing the img tag with this should do the trick:
I made the change to worker in pushkin-consortium/pushkin-worker#29, but CLI, API, and client should have their readme updated accordingly. We can also ditch the images folder for each of these packages. In the case of CLI,
"images/*"
should be removed from thefiles
property inpackage.json
.The text was updated successfully, but these errors were encountered: