Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

jest test suite #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Weiiirrr
Copy link

@Weiiirrr Weiiirrr commented Jun 6, 2023

Please review the Jest test code. Basecamp to-do is here.

@Weiiirrr Weiiirrr requested review from hzeng2 and jessestorbeck June 6, 2023 17:18
@jkhartshorne
Copy link
Contributor

@jessestorbeck @hzeng2 -- reminder.

Copy link

@hzeng2 hzeng2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Weiiirrr -- I could get all test pass. However I had to run yarn add -D jest-environment-jsdom whenever it's the first time I test in a folder (i.e. pushkin-exptemplates-basic, pushkin-exptemplates-lexical, or pushkin-exptemplates-reading). Do you think it's something that could be configured like this? To avoid manually running yarn add -D jest-environment-jsdom often.

@jkhartshorne
Copy link
Contributor

@Weiiirrr -- you should be able to add jest-environment-jsdom to the repo, following your instructions. Or follow @hzeng2 's suggestion above. Can you please make that update, commit, and push before we merge? Thanks!

@Weiiirrr
Copy link
Author

Hi @hzeng2, I revised the configuration and pushed it. Can you test it again to check if it works? Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants