Feature/pnm #48
Open
Feature/pnm #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aman035
approved these changes
Aug 13, 2025
When running curl | bash, stdin is the pipe but stderr is still connected to the terminal. Check stderr (-t 2) instead of stdin to properly detect interactive mode for log viewer. This ensures remote installer shows the same interactive TUI with sticky footer as local installation.
When running 'curl | bash', all file descriptors (stdin, stdout, stderr) are non-TTY because bash runs as a subprocess with piped input. However, /dev/tty always points to the controlling terminal when available. This fix ensures remote installer shows interactive log viewer with sticky footer, matching the local installation behavior. Previous attempts: - Checking stderr (-t 2) failed because ALL FDs are non-TTY in piped context - Checking stdin/stdout (-t 0 && -t 1) is correct for prompts but not for detecting terminal availability This resolves the issue where remote installation showed non-interactive logs mode instead of the interactive TUI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.