Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: init did tx payload #5

Merged
merged 2 commits into from
Oct 4, 2024
Merged

refactor: init did tx payload #5

merged 2 commits into from
Oct 4, 2024

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Oct 3, 2024

  • DID cann be removed since it can be derived out of masterPubKey itself DID = PUSH_DID:sha256_HASH_OF_MASTER_PUB_KEY
  • Added signature to walletToEncDerivedKey to make sure fake web3 wallets cannot be attached to DID. For eg - without signature there is no way to determine that the web3 wallet encrypted the key or not

@Aman035 Aman035 requested a review from Igx22 October 3, 2024 17:21
@Igx22 Igx22 merged commit 958ce4d into main Oct 4, 2024
0 of 3 checks passed
@Aman035 Aman035 deleted the modify-init-did branch October 7, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants