Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

231 define adequate interfaces #234

Merged
merged 10 commits into from
Jan 5, 2024
Merged

231 define adequate interfaces #234

merged 10 commits into from
Jan 5, 2024

Conversation

Zartaj0
Copy link
Member

@Zartaj0 Zartaj0 commented Dec 15, 2023 •
edited by zaryab2000
Loading

This PR includes updated interfaces for Core and Comm with all the public/external functions mentioned .

Solves #231 and #243

@Zartaj0 Zartaj0 requested a review from zaryab2000 December 15, 2023 06:07
@zaryab2000 zaryab2000 self-assigned this Dec 19, 2023
@zaryab2000 zaryab2000 added the enhancement New feature or request label Dec 19, 2023
Zartaj0
Zartaj0 commented Dec 21, 2023
View reviewed changes
Copy link
Member Author

@Zartaj0 Zartaj0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zartaj0
Copy link
Member Author

Zartaj0 commented Jan 2, 2024

@zaryab2000 we can merge this I think, if there are no more changes required.

@zaryab2000 zaryab2000 added the priority-1 Indicates highest priority label Jan 3, 2024
Zartaj0
Zartaj0 commented Jan 5, 2024
View reviewed changes
Copy link
Member Author

@Zartaj0 Zartaj0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to resolve the conflicts.

Zartaj0
Zartaj0 commented Jan 5, 2024
View reviewed changes
Copy link
Member Author

@Zartaj0 Zartaj0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good @zaryab2000

@zaryab2000 zaryab2000 merged commit 11f8bb6 into 193-unit-tests-feePoolStaking Jan 5, 2024
@zaryab2000 zaryab2000 deleted the 231-define-adequate-interfaces branch February 9, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaryab2000 zaryab2000 zaryab2000 approved these changes

Assignees

@zaryab2000 zaryab2000

Labels
enhancement New feature or request priority-1 Indicates highest priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zartaj0 @zaryab2000