Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

😈 [Feature Enhancement] - <Define adequate interfaces for Core and Communicator contract> #231

Closed
6 tasks
zaryab2000 opened this issue Dec 5, 2023 · 0 comments
Closed
6 tasks

😈 [Feature Enhancement] - <Define adequate interfaces for Core and Communicator contract> #231

zaryab2000 opened this issue Dec 5, 2023 · 0 comments
Assignees
@zaryab2000
Labels
enhancement New feature or request priority-2 Medium priority
Milestone
Push Core V2.5 (a...

Comments

@zaryab2000
Copy link
Collaborator

zaryab2000 commented Dec 5, 2023 •
edited
Loading

Feature name

No response

Describe the Enhancement

Include the following changes in the contract structure

  • Define an adequate interface for Core and Comm
  • Include events within the interface itself for respective contracts
  • Include the important public/external functions in the interface. Avoid including onlyAdmin functions in the interface for any contract
  • Include natspec for all events and functions in interfaces
  • Remove unwanted interface files
  • Rename inadequate interface files

POC if available

No response

Contract Name

Core Contract, Comm Contract
@zaryab2000 zaryab2000 added enhancement New feature or request priority-2 Medium priority labels Dec 5, 2023
@zaryab2000 zaryab2000 added this to the New Fee Pool Contract milestone Dec 5, 2023
@Zartaj0 Zartaj0 mentioned this issue Dec 15, 2023
Merged
@zaryab2000 zaryab2000 assigned zaryab2000 and unassigned Zartaj0 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaryab2000 zaryab2000

Labels
enhancement New feature or request priority-2 Medium priority
Projects
None yet
Milestone
Push Core V2.5 (and Clean-Ups)
Development

When branches are created from issues, their pull requests are automatically linked.

231-feature-enhancement-define-adequate-interfaces-for-core-and-communicator-contract push-protocol/push-smart-contracts
2 participants
@zaryab2000 @Zartaj0