Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix viem support, add ethers support #929

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Dec 18, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

File: packages/restapi/package.json

  1. In the "dependencies" section, there is a missing comma after the last package ("video-stream-merger"). Add a comma after "video-stream-merger".

  2. In the "scripts" section, the "test" script is not properly formatted. Add a closing curly brace at the end of the script.

  3. In the "devDependencies" section, there is a missing comma after the last package ("typescript"). Add a comma after "typescript".

All looks good.

File: packages/restapi/src/lib/channels/subscribe.ts

  1. In the subscribe function, there is a missing closing parenthesis after the line " 'Subscribe'". Add a closing parenthesis after "Subscribe'".

  2. In the subscribe function, there is a missing closing parenthesis after the line " 'Subscribe').". Add a closing parenthesis after "'Subscribe')".

  3. In the subscribe function, there is a missing closing parenthesis after the line "'Subscribe')". Add a closing parenthesis after "'Subscribe')".

  4. In the subscribe function, there is a missing closing parenthesis after the line "messageInformation,". Add a closing parenthesis after "messageInformation".

  5. In the subscribe function, there is a missing closing parenthesis after the line "messageInformation,". Add a closing parenthesis after "messageInformation".

  6. In the subscribe function, there is a missing closing parenthesis after the line "...messageInformation,". Add a closing parenthesis after "messageInformation".

  7. In the catch block, there is a missing closing parenthesis after "JSON.stringify(err)". Add a closing parenthesis after "JSON.stringify(err)".

All looks good.

File: packages/restapi/src/lib/channels/subscribeV2.ts

  1. In the subscribeV2 function, there is a missing closing parenthesis after the line "'Subscribe', settings". Add a closing parenthesis after "settings".

  2. In the subscribeV2 function, there is a missing closing parenthesis after the line "messageInformation,". Add a closing parenthesis after "messageInformation".

  3. In the subscribeV2 function, there is a missing closing parenthesis after the line "'Data'". Add a closing parenthesis after "'Data'".

  4. In the subscribeV2 function, there is a missing closing parenthesis after the line "messageInformation,". Add a closing parenthesis after "messageInformation".

  5. In the subscribeV2 function, there is a missing closing parenthesis after the line "messageInformation.data,". Add a closing parenthesis after "messageInformation.data".

  6. In the catch block, there is a missing closing parenthesis after "JSON.stringify(err)". Add a closing parenthesis after "JSON.stringify(err)".

All looks good.

File: packages/restapi/src/lib/channels/unsubscribe.ts

  1. In the unsubscribe function, there is a missing closing parenthesis after the line "'Unsubscribe'". Add a closing parenthesis after "'Unsubscribe'".

  2. In the unsubscribe function, there is a missing closing parenthesis after the line "'Unsubscribe'". Add a closing parenthesis after "'Unsubscribe'".

  3. In the unsubscribe function, there is a missing closing parenthesis after the line "messageInformation,". Add a closing parenthesis after "messageInformation".

  4. In the unsubscribe function, there is a missing closing parenthesis after the line "messageInformation,". Add a closing parenthesis after "messageInformation".

  5. In the unsubscribe function, there is a missing closing parenthesis after the line "'Unsubscribe')". Add a closing parenthesis after "'Unsubscribe')".

  6. In the catch block, there is a missing closing parenthesis after "JSON.stringify(err)". Add a closing parenthesis after "JSON.stringify(err)".

All looks good.

File: packages/restapi/src/lib/channels/unsubscribeV2.ts

  1. In the unsubscribeV2 function, there is a missing closing parenthesis after the line "'Unsubscribe'". Add a closing parenthesis after "'Unsubscribe'".

  2. In the unsubscribeV2 function, there is a missing closing parenthesis after the line "'Unsubscribe'". Add a closing parenthesis after "'Unsubscribe'".

  3. In

@mohammeds1992 mohammeds1992 merged commit 636b64e into alpha Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants