-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
897 improvement proposal spaces high level functions #898
897 improvement proposal spaces high level functions #898
Conversation
File: packages/restapi/src/lib/chat/getGroupMembers.ts
The code block inside the try-catch statement is not properly formatted. The line with the 'if (role) {' statement is missing a closing bracket '}'. The line with 'requestUrl += The error handling in the catch block should be improved. The console.error statement does not provide enough information about the error. It should be updated to something like:
Instead of re-throwing a new error, the catch block can simply throw the existing error. The code block is missing a closing bracket '}' at the end. File: packages/restapi/src/lib/chat/helpers/payloadHelper.ts
The code block is missing a closing bracket '}' at the end. File: packages/restapi/src/lib/pushapi/PushAPI.ts
The code block is missing a closing bracket '}' at the end. |
Documentation needs to be updated for this |
* feat(spaces): add high level audio methods * fix: socket url fix (#995) * feat(spaces-highlevel-audio-methods): add media function in Spaces class --------- Co-authored-by: Mohammed S <[email protected]>
Notion Doc: https://www.notion.so/pushprotocol/Push-Spaces-API-Class-Call-1-5-d3918f4255ad40b9916d276c3e900d52?pvs=4