Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

897 improvement proposal spaces high level functions #898

Merged

Conversation

mohammeds1992
Copy link
Collaborator

@mohammeds1992 mohammeds1992 commented Nov 28, 2023

@mohammeds1992 mohammeds1992 linked an issue Nov 28, 2023 that may be closed by this pull request
@mohammeds1992 mohammeds1992 changed the base branch from main to alpha November 28, 2023 21:32
@mohammeds1992 mohammeds1992 changed the base branch from alpha to main November 28, 2023 21:32
Copy link

File: packages/restapi/src/lib/chat/getGroupMembers.ts

  • The import statement for 'axios' is missing.
  • The import statement for 'Constants' is incorrect. It should be imported from '../constants'.
  • The import statement for 'ENV' is missing.
  • The import statement for 'ChatMemberProfile' is missing.

The code block inside the try-catch statement is not properly formatted. The line with the 'if (role) {' statement is missing a closing bracket '}'. The line with 'requestUrl += &role=${encodeURIComponent(role)};' statement is missing a closing bracket '}'.

The error handling in the catch block should be improved. The console.error statement does not provide enough information about the error. It should be updated to something like:

console.error('[Push SDK] - API - Error:', error);

Instead of re-throwing a new error, the catch block can simply throw the existing error.

The code block is missing a closing bracket '}' at the end.


File: packages/restapi/src/lib/chat/helpers/payloadHelper.ts

  • The import statement for 'getAllGroupMembers' is missing.

The code block is missing a closing bracket '}' at the end.


File: packages/restapi/src/lib/pushapi/PushAPI.ts

  • The import statement for 'ENV' is missing.
  • The import statement for 'PACKAGE_BUILD' is missing.
  • The import statement for 'SignerType' is missing.
  • The import statement for 'ProgressHookType' is missing.
  • The import statement for 'InfoOptions' is missing.
  • The import statement for 'PushAPIInitializeProps' is missing.
  • The import statement for 'PUSH_USER' is missing.
  • The import statement for 'PUSH_CHAT' is missing.
  • The import statement for 'Chat' is missing.
  • The import statement for 'Profile' is missing.
  • The import statement for 'Encryption' is missing.
  • The import statement for 'User' is missing.
  • The import statement for 'PushStream' is missing.
  • The import statement for 'Channel' is missing.
  • The import statement for 'Notification' is missing.
  • The import statement for 'PushStreamInitializeProps' is missing.
  • The import statement for 'STREAM' is missing.
  • The import statement for 'ALPHA_FEATURE_CONFIG' is missing.
  • The import statement for 'Space' is missing.

The code block is missing a closing bracket '}' at the end.


@Aman035
Copy link
Member

Aman035 commented Dec 15, 2023

Documentation needs to be updated for this

madhur-push and others added 4 commits January 8, 2024 17:56
* feat(spaces): add high level audio methods

* fix: socket url fix (#995)

* feat(spaces-highlevel-audio-methods): add media function in Spaces class

---------

Co-authored-by: Mohammed S <[email protected]>
@madhur-push madhur-push changed the base branch from main to alpha January 17, 2024 12:12
@mohammeds1992 mohammeds1992 merged commit c9ddf4d into alpha Feb 7, 2024
1 check failed
@madhur-push madhur-push deleted the 897-improvement-proposal-spaces-high-level-functions branch February 12, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - Spaces high level functions
3 participants