Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed arbitrum spelling and logo #891

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

KlausMikhaelson
Copy link
Contributor

No description provided.

Copy link

File: packages/uiweb/src/lib/components/chat/CreateGroup/AddCriteria.tsx

  1. In the dropdownChainsValues array, each object should have a unique id property. Currently, the id property is duplicated for all objects. It should be updated as follows:
const dropdownChainsValues: Array<DropdownValueType> = [
  {
    id: 0,
    value: BLOCKCHAIN_NETWORK[env].ETHEREUM,
    title: 'Ethereum',
    icon: EthereumSvg,
    function: () => setSelectedChainValue(0),
  },
  {
    id: 1,
    value: BLOCKCHAIN_NETWORK[env].POLYGON,
    title: 'Polygon',
    icon: PolygonSvg,
    function: () => setSelectedChainValue(1),
  },
  {
    id: 2,
    value: BLOCKCHAIN_NETWORK[env].BSC,
    title: 'BSC',
    icon: BSCSvg,
    function: () => setSelectedChainValue(2),
  },
  {
    id: 3,
    value: BLOCKCHAIN_NETWORK[env].OPTIMISM,
    title: 'Optimism',
    icon: OptimismSvg,
    function: () => setSelectedChainValue(3),
  },
  {
    id: 4,
    value: BLOCKCHAIN_NETWORK[env].ARBITRUM,
    title: 'Arbitrum',
    icon: ArbitrumSvg,
    function: () => setSelectedChainValue(4),
  },
];
  1. The onQuantityChange function is missing a closing curly brace. It should be updated as follows:
const onQuantityChange = (e: any) => {
  setQuantity({ ...quantity, value: e.target.value });
};
  1. In the verifyAndDoNext function, the category variable is incorrectly defined inside the ternary operator. It should be updated as follows:
const category: string =
  _type === 'PUSH'
    ? (dropdownCategoryValues[_type] as DropdownValueType[])[selectedCategoryValue].value || CATEGORY.ERC20
    : CATEGORY.ROLES;
  1. In the verifyAndDoNext function, the subCategory variable is incorrectly defined inside the if statement. It should be updated as follows:
let subCategory = SUBCATEGORY.DEFAULT;
if (_type === 'PUSH') {
  if (category === CATEGORY.ERC20 || category === CATEGORY.ERC721) {
    subCategory = SUBCATEGORY.HOLDER;
  } else if (category === CATEGORY.CUSTOM_ENDPOINT) {
    subCategory = SUBCATEGORY.GET;
  }
}

File: packages/uiweb/src/lib/icons/arbitrum.svg

  1. There are missing closing tags for the style elements. It should be updated as follows:
<style>
  .d {
    fill: #fff;
  }

  .e {
    fill: #9dcced;
  }
  
  .f {
    fill: #213147;
  }
  
  .g {
    fill: #12aaff;
  }
</style>

@mohammeds1992 mohammeds1992 merged commit 55fbcdb into alpha Nov 28, 2023
1 check passed
@KlausMikhaelson KlausMikhaelson deleted the arbitrum-spelling-fix branch December 1, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants