Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user keys verification issue - warn log #877

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Nov 24, 2023

No description provided.

Copy link

File: packages/restapi/src/lib/helpers/crypto.ts

  • There is commented code around line 4 which can be removed.

  • There is an unresolved TODO comment around line 7. Please add a description of what needs to be done and remove the TODO comment once it is completed.

  • In the verifyProfileKeys function, there is a missing closing curly brace for the if (parsedPublicKey === undefined) condition around line 27. Add a closing curly brace after the throw new Error('Invalid Public Key');.

  • In the verifyProfileKeys function, there is a missing closing curly brace for the if (!isValidSig) condition around line 47. Add a closing curly brace after the throw new Error('Invalid Signature');.

  • In the validatePassword function, there is a typo in the function name. It should be validatePassword, not validatePssword.

  • In the validatePassword function, there is a missing closing curly brace for the function around line 75. Add a closing curly brace after the throw new Error('Password must be at least 8 characters long!');.

All looks good.

@Aman035 Aman035 merged commit 317ad5f into main Nov 24, 2023
1 check passed
@Aman035 Aman035 deleted the fix-user-verification-warning branch November 24, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants