Support chat class based #843

pritipsingh · 2023-11-15T10:43:00Z

Things changed:

Shifted to new class based components for support chat

github-actions · 2023-11-15T10:44:26Z

File: packages/examples/sdk-frontend-react/src/app/ChatSupportTest.tsx

Line 49: The theme prop should be assigned the theme variable defined earlier in the component. Replace theme={lightTheme} with theme={theme}.

File: packages/uiweb/src/lib/components/supportChat/Chat.tsx

Line 31: Remove the extra , after theme = { ...lightTheme },.
Line 73: Remove the , after toastType.
Line 150: The screenScrollPos state variable is missing the useState declaration. Add , setScreenScrollPos after const [lastThreadHashFetched, setLastThreadHashFetched] = useState<string | null>(null).
Line 176: Add a closing } after content.scrollTop = curScrollPos + (newScroll - oldScroll);.
Line 179: Remove the extra , after setLoading(false).

File: packages/uiweb/src/lib/components/supportChat/Modal.tsx

Line 30: Remove , after socketData.
Line 38: The greetingMsgObject.icon prop should use the btnColorPrimary property from the theme variable. Replace theme.btnColorPrimary with theme?.btnColorPrimary.
Line 48: Remove , after messageBeingSent.
Line 52: Remove , after messageBeingSent.
Line 58: Remove , after messageBeingSent.
Line 66: Remove , after messageBeingSent.
Line 73: Remove , after messageBeingSent.
Line 76: Add a closing } after scrollToBottom();.
Line 79: Add a closing } after '[connectedUser, env, account, socketData]'.
Line 113: Remove , after toastType.

File: packages/uiweb/src/lib/helpers/chat/chat.ts

This file appears to be empty. Please check if it should be included.

File: packages/uiweb/src/lib/hooks/useSDKSocket.ts

Line 21: Remove the unused import for createSocketConnection.
Line 21: Remove , EVENTS after createSocketConnection.
Line 28: Remove , userAlice after apiKey.
Line 33: Remove , userAlice after apiKey.
Line 47: Remove , userAlice after apiKey.

All looks good.

github-actions · 2023-11-15T10:52:46Z

All looks good.

mishramonalisha76

Remove console log
Clear unsused variables

packages/uiweb/src/lib/components/supportChat/Chat.tsx

packages/uiweb/src/lib/hooks/useSDKSocket.ts

mishramonalisha76

@pritipsingh the updation of message from socket is not working properly

github-actions · 2023-11-15T14:45:49Z

All looks good.

github-actions · 2023-11-15T15:00:33Z

File: packages/examples/sdk-frontend-react/src/app/ChatSupportTest.tsx

The provider prop is not used in the component. Consider removing it if it's not needed.
The primaryColor prop is defined in the component's prop type but not used in the component. Consider removing it if it's not needed.

File: packages/uiweb/src/lib/components/supportChat/AddressInfo.tsx

In the useEffect hook, the condition if(userAlice){ is missing the closing }. Please add it for correct code syntax.
The prop theme is not used in the Container component. Consider removing it if it's not needed.

File: packages/uiweb/src/lib/components/supportChat/Chat.tsx

The ButtonStyleProps interface is defined but unused. Consider removing it if it's not needed.
The export keyword is out of place. Please remove it.
The account prop is defined but not used in the component. Consider removing it if it's not needed.
The ChatProps interface is missing a closing }. Please add it for correct code syntax.
In the useEffect hook, the condition if(signer) { is missing the closing }. Please add it for correct code syntax.
In the same useEffect hook, the condition if (!account) { is missing the closing }. Please add it for correct code syntax.
In the same useEffect hook, the condition else{ is missing the closing }. Please add it for correct code syntax.
The accountadd state variable is defined but not used. Consider removing it if it's not needed.

File: packages/uiweb/src/lib/components/supportChat/ChatInput.tsx

The loading state variable is defined but not used. Consider removing it if it's not needed.
The SmileyIcon and AttachmentIcon imports are unused. Consider removing them if they're not needed.
The Spinner import is unused and seems to be from a wrong location. Please remove it if it's not needed.
The showEmojis state variable is defined but not used. Consider removing it if it's not needed.
The fileInputRef reference is unused. Consider removing it if it's not needed.
The filesUploading state variable is defined but not used. Consider removing it if it's not needed.
The env prop is defined but not used in the component. Consider removing it if it's not needed.
The socketData and setChatsSorted variables are defined but not used in the component. Consider removing them if they're not needed.
The ChangeEvent type import is unused. Consider removing it if it's not needed.

File: packages/uiweb/src/lib/types/index.ts

The IFeeds and Rules imports are unused. Consider removing them if they're not needed.
The signTypedData method definition in the viemSignerType interface is incomplete and contains an incorrect type annotation. Please fix it for correct code syntax.

mishramonalisha76 · 2023-11-15T15:00:30Z

packages/uiweb/src/lib/components/supportChat/Chat.tsx

-          setAccount(address);
+          setAccountadd(address);
+          const userAlice = await PushAPI.initialize(signer, {env: env , account:address});
+          setUserAlice(userAlice)
        }
        else{
-          setAccount(account);
+          setAccountadd(account);
+          const userAlice = await PushAPI.initialize(signer, {env: env , account:account}); 
+          setUserAlice(userAlice)


Can we do the initialize in a useEffect, this makes the code redundant?

packages/uiweb/src/lib/components/supportChat/ChatInput.tsx

mishramonalisha76 · 2023-11-15T15:00:56Z

packages/uiweb/src/lib/components/supportChat/ChatInput.tsx

+        // sendResponse.messageContent = message;
+        // setChatsSorted([...chats, sendResponse]);


Remove commented code

I am keeping this incase I want to shift to sorting message like this in the future. But rest every other comments I have removed

packages/uiweb/src/lib/components/supportChat/Chats.tsx

mishramonalisha76 · 2023-11-15T15:02:21Z

packages/uiweb/src/lib/components/supportChat/Modal.tsx

+  // const getUpdatedChats = (message:IMessageIPFS) =>{
+  //   console.log(message)
+  //   if (message && (supportAddress === pCAIP10ToWallet(message?.from))) {
+      // const chat = await decryptChat({ message, connectedUser, env });
+      // socketData.messagesSinceLastConnection.decrypted = true;

+  //     setChatsSorted([...chats, message]);
+  //   }
+  // }
+
+
+


remove this section

github-actions · 2023-11-15T16:25:38Z

File: packages/examples/sdk-frontend-react/src/app/ChatSupportTest.tsx

The ChatSupportTest component is missing the return type. It should be React.ReactElement or JSX.Element.

File: packages/uiweb/src/lib/components/supportChat/AddressInfo.tsx

The useState hook is missing a type declaration for the user state variable. It should be useState<any>({}).

File: packages/uiweb/src/lib/components/supportChat/Chat.tsx

The Chat component is missing the return type. It should be React.ReactElement or JSX.Element.
The account prop in the ChatProps type declaration is not indented properly.
The export keyword is misplaced, it should be at the beginning of the line.
There are unnecessary empty lines and comments in the code.

File: packages/uiweb/src/lib/components/supportChat/ChatInput.tsx

The ChatInput component is missing the return type. It should be React.ReactElement or JSX.Element.
The handleKeyPress function should be indented properly.
The textOnChange function should be indented properly.

File: packages/uiweb/src/lib/components/supportChat/Chats.tsx

The Chats component is missing the return type. It should be React.ReactElement or JSX.Element.

File: packages/uiweb/src/lib/components/supportChat/Modal.tsx

The Modal component is missing the return type. It should be React.ReactElement or JSX.Element.

File: packages/uiweb/src/lib/helpers/chat/chat.ts

It seems like the chat.ts file is missing and should be reviewed.

File: packages/uiweb/src/lib/hooks/useSDKSocket.ts

It seems like the useSDKSocket.ts file is missing and should be reviewed.

File: packages/uiweb/src/lib/types/index.ts

The ethersV5SignerType type in the index.ts file is missing and should be reviewed.

File: packages/uiweb/yarn.lock

The yarn.lock file is not supposed to be reviewed as part of the code.

github-actions · 2023-11-15T18:04:52Z

All looks good.

github-actions · 2023-11-16T10:34:38Z

All looks good.

pritipsingh added 2 commits November 15, 2023 03:01

fix: changes-suppport chat

9b0a924

fix: new stream added

e2a9a06

pritipsingh requested a review from mishramonalisha76 November 15, 2023 10:43

fix: removed unn consolelogs

cc9557e

mishramonalisha76 suggested changes Nov 15, 2023

View reviewed changes

packages/uiweb/src/lib/components/supportChat/Chat.tsx Outdated Show resolved Hide resolved

packages/uiweb/src/lib/hooks/useSDKSocket.ts Outdated Show resolved Hide resolved

mishramonalisha76 reviewed Nov 15, 2023

View reviewed changes

fix: requested changed

fcd8614

fix: fixed minor issues

e33870f

mishramonalisha76 approved these changes Nov 15, 2023

View reviewed changes

mishramonalisha76 suggested changes Nov 15, 2023

View reviewed changes

fix: socket connection

697ab6a

fix: timestamp helper created, removed extra code

f6a3607

mishramonalisha76 approved these changes Nov 16, 2023

View reviewed changes

fix: changed userAlice to pushUser

fdb5eb6

mohammeds1992 approved these changes Nov 16, 2023

View reviewed changes

mohammeds1992 merged commit b364cee into main Nov 16, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support chat class based #843

Support chat class based #843

pritipsingh commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

mishramonalisha76 left a comment

mishramonalisha76 left a comment

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

mishramonalisha76 Nov 15, 2023

mishramonalisha76 Nov 15, 2023

pritipsingh Nov 15, 2023

mishramonalisha76 Nov 15, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 16, 2023

		// sendResponse.messageContent = message;
		// setChatsSorted([...chats, sendResponse]);

Support chat class based #843

Support chat class based #843

Conversation

pritipsingh commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

mishramonalisha76 left a comment

Choose a reason for hiding this comment

mishramonalisha76 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

mishramonalisha76 Nov 15, 2023

Choose a reason for hiding this comment

mishramonalisha76 Nov 15, 2023

Choose a reason for hiding this comment

pritipsingh Nov 15, 2023

Choose a reason for hiding this comment

mishramonalisha76 Nov 15, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 16, 2023