-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: socket issue & Chat keeps on going to top #832
Conversation
All looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I am sending a text it is scrolling to top and then scrolls back to bottom
@KlausMikhaelson check now |
File: packages/examples/sdk-frontend-react/src/app/ChatSupportTest.tsx
File: packages/uiweb/src/lib/components/supportChat/Chat.tsx
File: packages/uiweb/src/lib/components/supportChat/Modal.tsx
Overall, the code looks good with some minor issues mentioned above. |
const curScrollPos = content.scrollTop; | ||
const oldScroll = content.scrollHeight - content.clientHeight; | ||
|
||
await getChatCall(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need to await this function here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KlausMikhaelson it is fetching all the history chats from PushAPI and hence it's nice to make it an async call
Things that are fixed for Support chat: