Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix deprecation warn #801

Closed
wants to merge 1 commit into from
Closed

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Oct 23, 2023

What this Pr does

  1. Changes channel.subscribers to an paginated API
  2. Removes the deprecation warn
  3. Chnages the Response structure from. string [] to {itemCount: number , subscribers : string []}

!!! This is a breaking change

@github-actions
Copy link

File: packages/restapi/src/lib/pushNotification/PushNotificationTypes.ts

  1. In the ChannelInfoOptions type, there is a syntax error. The closing bracket is missing.
    Replace:

    export type ChannelInfoOptions = {
      channel?: string;
    export type SubscribeUnsubscribeOptions = {

    with:

    export type ChannelInfoOptions = {
      channel?: string;
    };
    export type SubscribeUnsubscribeOptions = {
  2. In the SubscribeUnsubscribeOptions type, there is a syntax error. The closing bracket is missing.
    Replace:

    export type UserSetting = {
      enabled: boolean;
      value?: number;
    export type AliasOptions = Omit<GetAliasInfoOptionsType, 'env'>;
    export enum FeedType {
      INBOX = 'INBOX',
      SPAM = 'SPAM',
    }

    with:

    export type UserSetting = {
      enabled: boolean;
      value?: number;
    };
    export type AliasOptions = Omit<GetAliasInfoOptionsType, 'env'>;
    export enum FeedType {
      INBOX = 'INBOX',
      SPAM = 'SPAM',
    }
  3. In the FeedsOptions type, there is a comment that is not closed properly.
    Replace:

    export type FeedsOptions = {
      //TODO: change it to string[] once we start supporting multiple channel
      channels?: [string];
      raw?: boolean;
    export type ChannelSearchOptions = {
      // Types related to notification

    with:

    export type FeedsOptions = {
      //TODO: change it to string[] once we start supporting multiple channel
      channels?: [string];
      raw?: boolean;
    };
    export type ChannelSearchOptions = {
      // Types related to notification
    };
  4. The IPayload type is empty. Please check if there are any missing properties or if it is intended to be empty.

@Aman035 Aman035 linked an issue Oct 23, 2023 that may be closed by this pull request
@Aman035
Copy link
Member Author

Aman035 commented Nov 22, 2023

Done by #864

@Aman035 Aman035 closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Deprecation Warn from channel.subscribers
1 participant