Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made Group Chat Modal More Persistent #1339

Merged
merged 6 commits into from
Jul 2, 2024
Merged

fix: made Group Chat Modal More Persistent #1339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7b85ab
fix: made Group Chat Modal More Persistent
abhishek-01k Jun 4, 2024
d6322c0
fix: prop issue fixed for UpdateUserProfileModal file as well
abhishek-01k Jun 7, 2024
0a9606a
fix: added closeModalOnClickAway to ChatView and UserProfile component
abhishek-01k Jun 12, 2024
adde0f0
fix: changed the name of the Modal ClickAway in Group Info and User P…
abhishek-01k Jun 24, 2024
9a48606
fix: pulled alpha changes to resolve conflicts on this branch
abhishek-01k Jul 1, 2024
490eddf
fix: changed the name of modal clickaway prop for user profile and ch…
abhishek-01k Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfileInfoModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,8 @@ export const GroupInfoModal = ({
if (chatProfileInfo) {
return (
<Modal
clickawayClose={onClose}
onClose={onClose}
closeonClickAway
modalBackground={groupInfoModalBackground}
modalPositionType={groupInfoModalPositionType}
>
Expand Down
4 changes: 3 additions & 1 deletion packages/uiweb/src/lib/components/chat/CreateGroup/CreateGroupModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export interface GroupInputDetailsType {

export const CreateGroupModal: React.FC<CreateGroupModalProps> = ({
onClose,
closeonClickAway = false,
modalBackground = MODAL_BACKGROUND_TYPE.OVERLAY,
modalPositionType = MODAL_POSITION_TYPE.GLOBAL,
onSuccess,
Expand Down Expand Up @@ -257,7 +258,8 @@ export const CreateGroupModal: React.FC<CreateGroupModalProps> = ({

return (
<Modal
clickawayClose={onClose}
onClose={onClose} // onClose function to close the modal
closeonClickAway={closeonClickAway} // boolean to handle the onClick activity of the user
modalBackground={modalBackground}
modalPositionType={modalPositionType}
>
Expand Down
1 change: 1 addition & 0 deletions packages/uiweb/src/lib/components/chat/exportedTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ export interface User {

export interface CreateGroupModalProps {
onClose: () => void;
closeonClickAway?: boolean;
modalBackground?: ModalBackgroundType;
modalPositionType?: ModalPositionType;
onSuccess?: (group: GroupInfoDTO | GroupDTO | undefined) => void;
Expand Down
17 changes: 10 additions & 7 deletions packages/uiweb/src/lib/components/chat/reusables/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import { device } from '../../../config';

interface IModalProps {
width?: string;
clickawayClose?: () => void;
onClose?: () => void;
closeonClickAway?: boolean;
children: any;
theme?: IChatTheme;
modalBackground?: ModalBackgroundType;
Expand All @@ -31,13 +32,13 @@ interface IModalHeader {
title: string;
}

const ClickawayCloseModal = ({ children, clickawayClose, width }: IModalProps) => {
const ClickawayCloseModal = ({ children, onClose, width, closeonClickAway }: IModalProps) => {
const modalRef = useRef(null);
const theme = useContext(ThemeContext);

useClickAway(modalRef, () => {
if (clickawayClose) {
clickawayClose();
if (onClose && closeonClickAway) {
onClose();
}
});

Expand All @@ -53,7 +54,8 @@ const ClickawayCloseModal = ({ children, clickawayClose, width }: IModalProps) =
};

export const Modal = ({
clickawayClose,
onClose,
closeonClickAway,
children,
width,
modalBackground = MODAL_BACKGROUND_TYPE.OVERLAY,
Expand All @@ -66,10 +68,11 @@ export const Modal = ({
modalBackground={modalBackground}
modalPositionType={modalPositionType}
>
{clickawayClose ? (
{closeonClickAway ? (
<ClickawayCloseModal
clickawayClose={clickawayClose}
onClose={onClose}
width={width}
closeonClickAway={closeonClickAway}
>
{children}
</ClickawayCloseModal>
Expand Down
Loading