Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed pcaip issue #1269

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented May 7, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@akp111 akp111 requested a review from Aman035 May 7, 2024 18:20
Copy link

github-actions bot commented May 7, 2024

In the notification.ts file:

  1. Typo: LIMTI should be corrected to LIMIT.
  2. Typo: notifcaiton should be corrected to notification.
  3. Missing closing brace '}' after Promise.all(promises);.
  4. Incorrect check for the condition in if (channels.length == 0). It should be if (channels.length === 0).
  5. Syntax error: The catch block is missing the closing brace '}'
  6. In the subscriptions method, there is an unnecessary throw new Error statement after the return.
  7. Typo: Vaidatiions should be corrected to Validations.

In the pushNotificationBase.ts file:

  1. Typo: LENGTH_LOWER_LIMTI should be corrected to LENGTH_LOWER_LIMIT.
  2. Unused import: channel from 'diagnostics_channel' is imported but not used.
  3. Typo: ban-ts-comment should be corrected to ban-ts-ignore.
  4. Typo: CORE_CONTRACT should be corrected to coreContract.
  5. The return statement is missing a closing brace '}' in the initializeCoreContract method.
  6. Typo: Derives should be corrected to Derive.
  7. Typo: Viam should be corrected to viem.
  8. The catch block in the verifyAlias method should have a closing brace '}' at the end.

Overall, the code seems to have some typos, syntax errors, and missing closing braces. Please correct these issues to ensure the code runs without errors.

All looks good.

@mohammeds1992 mohammeds1992 merged commit 07c4603 into main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants