Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha deployment #1262

Merged
merged 6 commits into from
May 3, 2024
Merged

Alpha deployment #1262

merged 6 commits into from
May 3, 2024

Conversation

mishramonalisha76
Copy link
Contributor

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

github-actions bot commented May 3, 2024

In packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx:

  1. The import for Section component from '../components/StyledComponents' seems to be incorrect. It should be '../../components/StyledComponents'.
  2. There are some commented-out props like // groupInfoModalPositionType and // verificationFailModalPosition in the ChatView component, which may need to be cleaned up.

In packages/uiweb/package.json:

  1. There is a missing comma after the "uuid": "^9.0.1" line.

In packages/uiweb/src/lib/components/chat/ChatViewBubble/ChatViewBubble.tsx:

  1. The <Section> component is missing closing tags after {isGroup && chat?.fromCAIP10 !== user?.account && <SenderMessageProfilePicture chat={chat} />} and before {isGroup && chat?.fromCAIP10 !== user?.account && <SenderMessageAddress chat={chat} />}.

That's all the issues found. Everything else looks good.

All looks good.

@mishramonalisha76 mishramonalisha76 merged commit 7c6ccea into alpha May 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant