-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed placement of chat #1260
Conversation
In the provided code snippets, I found some mistakes and potential improvements:
There may be more issues to be checked thoroughly. After resolving these mentioned mistakes, please review the logic and functionality to ensure everything works as intended. |
In the file packages/uiweb/package.json:
After fixing the above issues, the package.json file should look like this: {
"name": "@pushprotocol/uiweb",
"version": "0.0.1-alpha.46",
"publishConfig": {
"registry": "https://registry.npmjs.org/"
},
"dependencies": {
"@livekit/components-react": "^1.2.2",
"@livekit/components-styles": "^1.0.6",
"@livepeer/react": "^2.6.0",
"@pushprotocol/socket": "^0.5.0",
"@unstoppabledomains/resolution": "^8.5.0",
"@web3-onboard/coinbase": "^2.2.5",
"@web3-onboard/core": "^2.21.1",
"@web3-onboard/injected-wallets": "^2.10.5",
"@web3-onboard/react": "^2.8.9",
"@web3-onboard/walletconnect": "^2.4.6",
"@web3-react/injected-connector": "^6.0.7",
"date-fns": "^2.28.0",
"emoji-picker-react": "^4.4.9",
"ethers": "^5.6.8",
"gif-picker-react": "^1.1.0",
"html-react-parser": "^1.4.13",
"livekit-client": "^1.13.3",
"moment": "^2.29.4",
"react-easy-crop": "^4.1.4",
"react-icons": "^4.10.1",
"react-image-file-resizer": "^0.4.7",
"animejs": "^2.2.0",
"classnames": "^2.2.5",
"raf": "^3.4.0",
"react-toastify": "^9.1.3",
"react-twitter-embed": "^4.0.4",
"uuid": "^9.0.1"
},
"peerDependencies": {
"@pushprotocol/restapi": "1.7.13",
"react": ">=16.8.0",
"styled-components": "^6.0.8"
}
} In the file packages/uiweb/src/lib/components/chat/ChatViewBubble/ChatViewBubble.tsx:
After fixing the above issues, the file should look like this: // Inside the SenderMessageProfilePicture component
{
chat.fromCAIP10 !== user?.account && (
<Section alignItems="start">
{pfp && (
<Image
src={pfp}
alt="profile picture"
width="40px"
height="40px"
borderRadius="50%"
/>
)}
</Section>
)
} // Inside the MessageWrapper component
</Section>
} // Inside the ChatViewBubble component
</MessageWrapper>
);
}; All looks good. |
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers