Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support chat v2 added (#1236) #1248

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

mishramonalisha76
Copy link
Contributor

  • feat: support chat v2 added

  • fix: changed supportchatv2 to chatwidget

  • fix: changed support chat to chatwidget

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

* feat: support chat v2 added

* fix: changed supportchatv2 to chatwidget

* fix: changed support chat to chatwidget
@mishramonalisha76 mishramonalisha76 merged commit 7e589ca into alpha-deployment Apr 25, 2024
1 check passed
Copy link

In the file packages/examples/sdk-frontend-react/src/app/ChatSupportTest.tsx:

  1. The key prop in the ChatWidget component is not needed and should be removed.
  2. The closing tag for the ChatWidget component is missing.

In the file packages/examples/sdk-frontend-react/src/app/app.tsx:

  1. Some of the Link components are not closed properly, they are missing the closing tag.
  2. Within the Routes component, each Link to should have a closing tag.
  3. In the WidgetUIProvider component, the closing tag should be added.
  4. The position: number; line in the MessageCard component should be removed.

In the file packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx:

  1. The closing tag is missing in the getProfileName function.

In the file packages/uiweb/src/lib/components/chat/ChatViewBubble/ChatViewBubble.tsx:

  1. In the MessageCard component, there are conditional statements with missing brackets in the border, color, fontWeight, and bottom property settings.
  2. Section component within the MessageCard and FileCard components should be closed properly.
  3. The Image component in the FileCard has missing closing tags.
  4. The return statement in the if conditions in the ChatViewBubble is missing curly braces.

The other files were not reviewed as they were not mentioned in the request.

Overall, please correct the issues mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant