Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed preview bugs #1078

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix: fixed preview bugs #1078

merged 1 commit into from
Feb 1, 2024

Conversation

mishramonalisha76
Copy link
Contributor

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@mishramonalisha76 mishramonalisha76 merged commit 9961ab7 into alpha Feb 1, 2024
1 check passed
Copy link

github-actions bot commented Feb 1, 2024

In ChatUITest/ChatProfile.tsx:

  1. Line 16: The chatId prop is commented out and replaced with a different chatId. Please verify if this change is intentional.

In ChatPreview.tsx:

  1. Line 19: The IThemeProps interface is missing closing brackets ('}').
  2. Line 44: Missing closing bracket for the getProfileName function.
  3. Line 68: Missing closing bracket for the ChatPreview component.
  4. Line 126: Missing closing bracket for the ChatPreviewContainer styled component.
  5. Line 149: Missing closing bracket for the Account styled component.
  6. Line 189: Missing closing bracket for the Dated styled component.
  7. Line 225: Missing closing bracket for the Message styled component.
  8. Line 269: Missing closing bracket for the Badge styled component.

In ChatPreviewList.tsx:

  1. Line 43: The blur prop in the IThemeProps interface is missing a question mark ('?') to make it optional.
  2. Line 59: Missing closing bracket for the IChatPreviewListMeta interface.
  3. Line 73: Missing closing bracket for the IChatPreviewList interface.
  4. Line 85: Missing closing bracket for the ChatPreviewList component.

In ChatProfile.tsx:

  1. Line 97: The chatProfileHelperComponent prop has a default value of null. Please confirm if this is intentional or if a different default value should be used.
  2. Line 159: Missing closing bracket for the fetchProfileData function.
  3. Line 259: The getImage function has a return statement that is not reachable. This should be removed or modified.
  4. Line 275: The getProfileName function has a return statement that is not reachable. This should be removed or modified.
  5. Line 297: Missing closing bracket for the ChatProfile component.
  6. Line 329: Missing closing bracket for the ProfileContainer styled component.
  7. Line 365: Missing closing bracket for the Container styled component.
  8. Lines 401-410: Potential unused code. Please check if this code is necessary.

Note: The provided code snippets are incomplete and there may be additional issues or missing code outside the provided snippets. Please review the full codebase for any other potential issues.

@mishramonalisha76 mishramonalisha76 deleted the preview-bugs branch March 5, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant