Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.13 #155

Merged
merged 11 commits into from
Jan 10, 2025
Merged

Release 0.13 #155

merged 11 commits into from
Jan 10, 2025

Conversation

rohitmalhotra1420
Copy link
Collaborator

No description provided.

Copy link

Code Review Feedback:

File: android/app/build.gradle

  1. There is a typo in the declaration of jscFlavor. The correct syntax should be:
    def jscFlavor = 'org.webkit:android-jsc:+'
  2. The method reactNativeArchitectures is not called anywhere within the file, it seems to be defined but not utilized. Consider removing it if it's not needed.
  3. There is a missing closing brace } after the versionName for the staging product flavor.
  4. The splits configuration is not properly closed with a closing brace }.
  5. There are errors in the signingConfigs section as it doesn't seem to be properly structured, each signing config block needs to be enclosed within {}.
  6. The buildTypes section is not properly formatted. Each build type configuration should be enclosed within a block {}.
// Corrected `jscFlavor` declaration
def jscFlavor = 'org.webkit:android-jsc:+'

// Other corrections are needed as mentioned above
...
...

All looks good.

---

#### File: ios/epns.xcodeproj/project.pbxproj
1. In the `ASSETCATALOG_COMPILER_APPICON_NAME`, `ASSETCATALOG_COMPILER_APPICON_NAME`, `OTHER_SWIFT_FLAGS`, and `SWIFT_VERSION` settings, the corresponding closing quotes are missing.
2. The `E74C05D429C06A2800C20AC1 /* Debug */` configuration seems to have a missing opening brace `{` before the settings.
3. The `E74C05D529C06A2800C20AC1 /* Release */` and `E74C05D429C06A2800C20AC1 /* Debug */` configurations are not closed with a closing brace `}`.

```bash
# Corrections are needed as mentioned above
...
...
...

All looks good.

@rohitmalhotra1420 rohitmalhotra1420 merged commit b6f2039 into main Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants