Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMAPP-149: Integrate channel categories #151

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

meKushdeepSingh
Copy link
Collaborator

Integration

  • The Channel Screen will feature a horizontally scrollable category list.
  • By default, the 'All' category will be selected, and users can switch to any other category.
  • The left and right caret icon buttons have been removed as the list is now scrollable.
  • Selecting a category will reset any previously applied search or category filters.
  • The onPress event for the active category will now be disabled.
  • Two messages will be used for scenarios with no data:
    • For search: "No channels match your query. Please search for another name or address."
    • For default or category change: "No results available."

Integrated UI:
Screenshot 2025-01-08 at 1 24 53 PM

- Completed UI integration
- Completed API integration
- Work in progress: Handling search and category filter functionality
- Implemented handling of search and category filters.
- Ensured reset of the previous filter when a new one is applied.
- Disabled onPress event for the active category.
- Added a new message to display when data is unavailable.
@meKushdeepSingh meKushdeepSingh self-assigned this Jan 8, 2025
@meKushdeepSingh meKushdeepSingh linked an issue Jan 8, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 8, 2025

In the file src/Globals.ts:

  1. There is a missing closing brace '}' for the SOCKETS object.
  2. The COLORS object is missing its closing brace '}'.
  3. The SCREENS object is missing its closing brace '}'.

In the file src/components/pill/Pill.tsx:

  1. Inside the StyleSheet.create, the inactiveView style object is missing its closing brace '}'.
  2. The fontWeight property should be 'fontWeight: '500'' instead of 'fontWeight: '500'.

In the file src/components/pill/Pill.types.ts:

  1. The PillData type definition is missing its closing brace '}'

In the file src/env.config.js:

  1. The IS_PROD_ENV constant is defined but not used.
  2. The line with the variable declaration for WC_RPC seems incomplete.

Please correct these issues and recheck the code.

All looks good.

Copy link

github-actions bot commented Jan 8, 2025

In the Globals.ts file, there seem to be a few issues:

  1. In the SOCKETS object, the STORAGE object is not properly closed with }.
SOCKETS: {
    USE_SOCKETS: true,
    STORAGE: {
      // Key-value pairs for storage
    },
  },
  1. In the COLORS object inside the ADJUSTMENTS object, the closing } is missing at the end.
ADJUSTMENTS: {
    SCREEN_GAP_HORIZONTAL: 10,
    SCREEN_GAP_VERTICAL: 10,
    DEFAULT_BIG_RADIUS: 10,
    DEFAULT_MID_RADIUS: 8,
    FEED_ITEM_RADIUS: 8,
    COLORS: {
      // Colors definitions
    },
  },
  1. In the Pill.tsx file, the activeView and inactiveView styles are missing closing }.
activeView: {
    backgroundColor: Globals.COLORS.BLACK,
},
inactiveView: {
    backgroundColor: Globals.COLORS.PILL_BG_DEFAULT,
},
  1. In the Pill.types.ts file, the PillData type is not properly closed with }.
export type PillData = {
  label: string;
};
  1. In the env.config.js file, the WC_RPC field is missing a value assignment.
WC_RPC: IS_PROD_ENV ? 'prod' : 'staging',
  1. There are references to objects like GLOBALS.LINKS and GLOBALS.CONTRACTS that are not defined in the provided code snippet, causing potential issues if not defined elsewhere.

After fixing the above issues, if there are no other mistakes, the code changes should be reviewed thoroughly, and if everything looks good from the logical standpoint, you can consider the code ready for production.

Let me know if you need further assistance or clarification.

Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meKushdeepSingh please add a video with all the detailed steps on the PR.

import {PillProps} from '.';

const Pill: FC<PillProps> = ({data, value, onChange, disabled}) => {
const isActive = useMemo(() => data.value === value, [value]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useMemo is not required.

@@ -91,6 +98,15 @@ const ChannelsDisplayer = () => {
} catch (e) {}
};

const handleCategoryChange = (category: string) => {
if (search.length > 0 || showSearchResults) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (search.length > 0 || showSearchResults) {
if (search.length || showSearchResults) {

- Minor changes in Pill and channelsDisplayer component
Copy link

github-actions bot commented Jan 9, 2025

In the file src/Globals.ts, it seems that there is a missing curly brace closing the SOCKETS object around line 54. It should be added to properly close the object.

Additionally, in the same file, there is a missing closing parenthesis for the PillData type in the file Pill.types.ts around line 7. It should be added to properly close the type definition.

Lastly, in the file src/env.config.js, there are some missing comma separators between the variables being destructured from the GLOBALS.LINKS object around line 47. Commas should be added to separate each variable.

Once these corrections are made, the code should be fine.

All looks good.

@rohitmalhotra1420 rohitmalhotra1420 merged commit 3d6d3d9 into main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel categories
2 participants