DMAPP-115: Integrate foreground notification for channels #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
meKushdeepSingh
commented
Dec 9, 2024
meKushdeepSingh
commented
- Display notification banner when the app is in the foreground state.
- Handle data updates when the home screen is open in the foreground.
- Implement notification banner press handling to navigate or update views as needed.
- Fix iOS notification sound issue to ensure proper audio playback for notifications.
- Added app logo as notification icon on Android - Display foreground notification for Channel module - Begin handling notification events (WIP)
- Update inbox and spam feed data when a notification is received while the app is in the foreground and the home screen is open. - Navigate to the appropriate tab and auto-select it when a notification banner is pressed.
- Added a function to root navigation to get current route params - Updated getRecentMessageNotifications function to get already received notification data in mobile app
…d Android - Display notification banner when the app is in the foreground state. - Handle data updates when the home screen is open in the foreground. - Implement notification banner press handling to navigate or update views as needed. - Fix iOS notification sound issue to ensure proper audio playback for notifications.
rohitmalhotra1420
changed the title
rohitmalhotra1420
changed the title
rohitmalhotra1420
requested changes
Dec 9, 2024
src/helpers/NotificationHelper.ts
Outdated
Comment on lines
94
to
121
| await notifee.displayNotification({ | ||
| id: remoteMessage.messageId, | ||
| title: remoteMessage.notification?.title, | ||
| body: remoteMessage.notification?.body, | ||
| ios: { | ||
| sound: 'default', | ||
| foregroundPresentationOptions: { | ||
| banner: true, | ||
| list: true, | ||
| badge: true, | ||
| sound: true, | ||
| }, | ||
| }, | ||
| android: { | ||
| channelId: 'default', | ||
| largeIcon, | ||
| smallIcon: | ||
| remoteMessage.notification?.android?.smallIcon ?? 'ic_notification', | ||
| color: | ||
| remoteMessage.notification?.android?.color ?? | ||
| Globals.COLORS.IC_NOTIFICATION, | ||
| circularLargeIcon: true, | ||
| pressAction: { | ||
| id: 'default', | ||
| }, | ||
| }, | ||
| data: remoteMessage.data, | ||
| }); |
There was a problem hiding this comment.
create a utility function which will accept remoteMessage and return the config
src/helpers/NotificationHelper.ts
Outdated
| id: notification.messageId, | ||
| title: notification?.title, | ||
| body: notification?.body, | ||
| ios: { | ||
| sound: 'default', |
src/redux/homeSlice.ts
Outdated
| type ReturnTypeHome = {home: HomeInitialState}; | ||
|
|
||
| const initialState: HomeInitialState = { | ||
| channelInboxNotificationAcknowledgement: { |
There was a problem hiding this comment.
we can remove channelInboxNotificationAcknowledgement
rohitmalhotra1420
approved these changes
Dec 9, 2024
- Added a utility function for displaying notifications using Notifee to streamline notification handling. - Removed the `channelInboxNotificationAcknowledgement` object state from `homeSlice` to simplify state management
rohitmalhotra1420
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.