Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMAPP-143: Fixed issue where sent messages were not appearing in new … #146

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

meKushdeepSingh
Copy link
Collaborator

…chats

  • Removed a condition that was preventing new messages from updating in the chat history. Messages now appear correctly in the history container.
New.chat.message.issue.fixed.mov

@meKushdeepSingh meKushdeepSingh self-assigned this Dec 5, 2024
@meKushdeepSingh meKushdeepSingh linked an issue Dec 5, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 5, 2024

  • In the line toastRef.current ? toastRef.current.showToast : null,, there is a missing parenthesis at the end of the line. It should be like this:
toastRef.current ? toastRef.current.showToast() : null,
  • The function if (!res) { is missing a closing curly brace.

  • In the onAccept function, the setisIntentReceivePage(false); statement should be setIsIntentReceivePage(false);.

  • The onDecline function is currently empty. May need to add functionality to it.

  • There is a commented out const dispatch = ...). It seems like it's a duplicate declaration. You may need to remove it.

  • In the handleSetReplyPayload function, there is a missing closing curly brace after animated: true,. It should be like this:

      animated: true,
    });
  • The console.log('err getting the date'); right before the return false; statement in the includeDate function will never execute as it is after a return statement. It seems like a leftover debug log that can be removed.

  • There is an unclosed curly brace at the end of the renderItem function. It should be closed.

  • In the handleSetReplyPayload function, the line textInputRef.current?.focus(); is missing a closing parenthesis before textInputRef.

  • In the handleOnScroll function, the SCORLL_OFF_SET seems to be a typo. It should be SCROLL_OFF_SET.

Other than the mentioned points, the code looks good.

@rohitmalhotra1420 rohitmalhotra1420 merged commit c973bf8 into main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sent Messages Not Appearing in New Chats
2 participants