Skip to content

(maint) - Fix nightlies #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

(maint) - Fix nightlies #395

merged 1 commit into from
May 15, 2025

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented May 15, 2025

Summary

Fixes broken test referring to old $::operatingsystem fact (we can only test for 'os' here, not for example 'os.family')
Hardens Unknown variable test

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review May 15, 2025 13:31
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner May 15, 2025 13:31
@david22swan david22swan merged commit 4438f40 into main May 15, 2025
6 checks passed
@david22swan david22swan deleted the maint-fix_nightlies branch May 15, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants