Skip to content
This repository was archived by the owner on Mar 28, 2019. It is now read-only.

Add notifier to puppet agent service #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theosotr
Copy link

@theosotr theosotr commented Feb 1, 2019

This pull request adds a missing notification to puppet agent's service from File[puppet_agent_service_conf].

@genebean
Copy link

genebean commented Feb 1, 2019

So... we are not actively using this module any more and it has been basicly orphaned for quite some time. I am happy to merge your PR if you have tested it yourself but would suggest moving to using https://forge.puppet.com/puppetlabs/puppet_agent or https://forge.puppet.com/theforeman/puppet instead.

@theosotr
Copy link
Author

theosotr commented Feb 1, 2019

Hi!
Thank you for your response.
I have built a tool that detects different kinds of bugs in Puppet modules such as missing notifiers, etc.
To evaluate my tool, I analyze many modules found in Forge.
My tool reports a missing notifier to puppet agent's service.
You can merge this pull request, if ypu that it is not false positive.
Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants