Skip to content

Conversation

@myhau
Copy link

@myhau myhau commented Jun 17, 2022

Kotlin DSL for Gradle is getting more and more popular. I'd even argue that it is the new default for some people/companies, but it might be just my echo chamber.

What do you think about the name of this template? Should this be named java-gradle-kts, java-gradle-kotlin-dsl or java-gradle-kotlin? Any other ideas?

@github-actions
Copy link

PR is now waiting for a maintainer to run the template acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-templates on the PR

@myhau myhau force-pushed the add-template-for-java-gradle-with-kotlin-dsl branch from 4fbf6ba to 5e8be8a Compare June 22, 2022 13:54
@github-actions
Copy link

PR is now waiting for a maintainer to run the template acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-templates on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the template acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-templates on the PR

@t0yv0
Copy link
Member

t0yv0 commented Mar 10, 2023

/run-acceptance-tests

@t0yv0 t0yv0 force-pushed the add-template-for-java-gradle-with-kotlin-dsl branch from cf38752 to 7bef8cf Compare March 10, 2023 18:44
@t0yv0
Copy link
Member

t0yv0 commented Mar 10, 2023

Sorry for the delay here. Tried it locally, this still works great on the latest versions. Checking if CI is happy.

@github-actions
Copy link

PR is now waiting for a maintainer to run the template acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-templates on the PR

@t0yv0
Copy link
Member

t0yv0 commented Mar 10, 2023

/run-acceptance-tests

@t0yv0
Copy link
Member

t0yv0 commented Mar 10, 2023

/run-templates

@t0yv0 t0yv0 requested a review from cnunciato March 10, 2023 19:00
@t0yv0
Copy link
Member

t0yv0 commented Mar 10, 2023

@cnunciato I've just verified this template locally and it's good to go. This LGTM if you'd like to adopt it into templates.

@myhau
Copy link
Author

myhau commented Aug 30, 2023

@cnunciato I've just verified this template locally and it's good to go. This LGTM if you'd like to adopt it into templates.

Hello 👋

@t0yv0, @cnunciato

Kotlin DSL is the new default for Gradle projects. See the official blog-post from Gradle team: link.

What do you think? Could we merge this?

I'm happy to provide more suggestions for a perfect name for this template. I can also improve the code, in case template-related things have changed in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants