(WIP) Change Environment.Exprs to be the AST of the root expression #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
reviewed
Nov 14, 2025
eval/eval.go
Outdated
| rotatePaths map[string]bool, | ||
| ) (*esc.Environment, RotationResult, syntax.Diagnostics) { | ||
| if env == nil || (len(env.Values.GetEntries()) == 0 && len(env.Imports.GetElements()) == 0) { | ||
| if env == nil || (len(env.Values.Entries) == 0 && len(env.Imports.GetElements()) == 0) { |
Member
There was a problem hiding this comment.
is there not a GetEntries method on *ObjectExpr? if there isn't, I think we probably need a nil check here (the original GetEntries check would check for a nil receiver and return an empty slice)
seanyeh
force-pushed
the
syeh/ranges-top-level-objectexpr
branch
from
df8d4d6 to
ec8fa2c
Compare
Contributor
Author
|
Unfortunately this causes some changes that aren't quite backwards-compatible so we're putting a hold on this for now - will revisit with a possibly different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/pulumi/pulumi-service/issues/34642